Review Discussion: Conditional Streaming vs Blanket Send-Once

Context

This PR switches all response delivery to send-once (emoji progress indicators + single message at completion), removing streaming edit entirely. This cleanly fixes bot-to-bot communication, but it also regresses the most common scenario: one human + one bot.

Line of Reasoning

1. The core problems this PR fixes are specifically two:

• The "..." placeholder triggers other bots in all mode (they respond to it as real content)
• Streaming edit delivers the final content via message_changed, which gets filtered by skip_subtype in mentions mode — so @mentions from bot replies are silently dropped

Both share the same root cause: no message events should appear on Slack before the reply is complete.

2. In mentions mode, do multiple bots tagged simultaneously interfere with each other?

Mostly no — each bot answers its own question and doesn't mention the other. An LLM could theoretically add an @mention on its own, but this is rare in practice and can be mitigated via system prompt.

3. What about allow_bot_messages = "off" (the default)?

All bot messages are dropped, including message_changed. Streaming edit is completely safe in this mode — there is no bot-to-bot problem to solve.

4. Conclusion: most users don't need to pay the UX cost for a bot-to-bot feature they haven't enabled.

Suggestion: Conditional Streaming

Branch behavior based on the allow_bot_messages config:

if allow_bot_messages == "off":              # default, majority of users
  -> streaming edit (good human UX, bot messages are dropped anyway)

if allow_bot_messages == "mentions" | "all":
  -> send-once (protects bot-to-bot communication)

Benefits:

• Default behavior (off) retains streaming with zero UX regression
• Decision is deterministic — purely config-driven, no edge cases
• Streaming edit code doesn't need to be deleted, just made conditional
• Users who enable bot-to-bot explicitly accept the send-once trade-off

This is not a blocker — the blanket send-once in this PR is correct and safe. This is a suggestion for a follow-up optimization so the default experience remains unchanged.

Follow-up commits pushed: conditional streaming + multi-bot fixes

Pushed 3 commits addressing the conditional streaming suggestion and two bugs found during multi-bot testing.

1. 7ee492c — feat(slack): conditional streaming edit based on allow_bot_messages

Implements the suggestion from the review: branch Slack response delivery based on config rather than blanket send-once.

Changes:

• Added edit_message() and use_streaming() to ChatAdapter trait (default: no-op / false)
• SlackAdapter implements edit_message via chat.update, returns use_streaming() = true when allow_bot_messages == Off
• stream_prompt() branches: streaming mode sends "…" placeholder + 1.5s edit loop; send-once mode accumulates and sends at completion
• Added format::truncate_chars() for streaming display truncation

2. d814158 — fix(discord): remove mention_roles from is_mentioned check

Bug: when multiple bots share a Discord channel, @mentioning one bot triggered the other. Root cause: the is_mentioned check included mention_roles — if both bots share a role, the role-based match fired for both.

Fix: removed the mention_roles clause. mentions_user_id() + raw content <@BOT_ID> check is sufficient and correctly scoped to the specific bot being mentioned.

3. 1260507 — fix(helm): add allowUserMessages for Discord in configmap

Bug: allowUserMessages was only rendered in the [slack] section of the Helm configmap template. Setting agents.kiro.discord.allowUserMessages=mentions via Helm was silently ignored — Discord always defaulted to involved.

Fix: added the same allowUserMessages block to the [discord] section with validation (involved / mentions).

Testing

Validated on local OrbStack cluster with two Kiro-powered bots (AgentBroker + AgentDealer) in the same Discord channel:

• ✅ @AgentBroker → only AgentBroker responds
• ✅ @AgentDealer → only AgentDealer responds
• ✅ Slack streaming edit works when allow_bot_messages = "off"
• ✅ Slack send-once works when allow_bot_messages = "mentions"
• ✅ allowUserMessages = "mentions" correctly requires @mention in Discord threads

No breaking changes — default behavior is unchanged.

變更摘要（繁體中文）

起因

處理 PR #420 的 review comment — 建議 Slack 的回覆方式不要一刀切改成 send-once，應該根據 allow_bot_messages 設定來決定。

完成的事項

1. Slack 條件式串流

• allow_bot_messages = "off"（預設）→ 串流編輯，使用者看到即時更新的回覆
• allow_bot_messages = "mentions" / "all" → 一次送出，避免 bot 對 bot 通訊被佔位符干擾

2. Discord 多 bot 修正

• 發現 is_mentioned 的 mention_roles 檢查有 bug — 同頻道兩個 bot 共用 role 時，@其中一個會觸發另一個
• 移除 mention_roles，只用 mentions_user_id 判斷

3. Helm chart 修正

• allowUserMessages 設定原本只對 Slack 生效，Discord 區塊漏掉了
• 補上後可以透過 Helm 控制 Discord bot 是否需要 @mention 才回覆

4. 部署 AgentDealer（第二個 bot）驗證

• 從 AgentBroker 的 PVC 複製認證資料
• 兩個 bot 共存同一頻道，各自只回應自己的 @mention

影響

零 breaking change，預設行為不變。

架構圖

                        條件式串流（Slack）
                        ==================

  allow_bot_messages = "off"（預設，大多數使用者）

    User: @Bot 幫我看 code
      │
      ▼
    Bot: "…"  ──1.5s──►  "正在分析..."  ──1.5s──►  "分析完成，這段 code..."
         │                     │                          │
      placeholder          chat.update                chat.update
      (即時回饋)           (串流更新)                 (最終結果)


  allow_bot_messages = "mentions" / "all"（bot 對 bot 模式）

    BotA: @BotB 幫我 deploy
      │
      ▼
    BotB: (靜靜等待完成...)
      │
      ▼
    BotB: "已部署到 staging ✅"
           │
        chat.postMessage
        (一次送出，不會觸發其他 bot)


                     多 Bot 修正（Discord）
                     ====================

  修正前（bug）:
  ┌─────────────────────────────────────┐
  │  User: @AgentDealer HI             │
  │         │                          │
  │         ├──► AgentDealer: 收到 ✅   │
  │         │                          │
  │         └──► AgentBroker: 也收到 ❌ │  ← mention_roles 誤判
  └─────────────────────────────────────┘

  修正後:
  ┌─────────────────────────────────────┐
  │  User: @AgentDealer HI             │
  │         │                          │
  │         ├──► AgentDealer: 收到 ✅   │  ← mentions_user_id 正確匹配
  │         │                          │
  │         └──► AgentBroker: 忽略 ✅   │  ← 不是 @我，不理
  └─────────────────────────────────────┘


                   OrbStack 驗證架構
                   ================

  ┌─ Kubernetes (OrbStack) ─────────────────────────────┐
  │                                                     │
  │  ┌─ openab-kiro (AgentBroker) ───────────────────┐  │
  │  │  openab → kiro-cli acp                        │  │
  │  │  Discord: #channel-1  +  Slack ✅              │  │
  │  │  PVC: openab-kiro (auth + settings)           │  │
  │  └───────────────────────────────────────────────┘  │
  │                                                     │
  │  ┌─ openab-dealer (AgentDealer) ─────────────────┐  │
  │  │  openab → kiro-cli acp                        │  │
  │  │  Discord: #channel-1 + #channel-2             │  │
  │  │  PVC: openab-dealer (cloned from kiro)        │  │
  │  └───────────────────────────────────────────────┘  │
  │                                                     │
  └─────────────────────────────────────────────────────┘

Related issues (POC validation for tonight's fixes):

• Fixes 🐍《華西街蛇女》— B2B AI 共創五言律詩接龍故事 #440
• Fixes 《華西街蛇女》—— B2B 即興創作完整紀錄 🐍🐻 #441

Note: Role mentions no longer trigger the bot

Commit c281b2e removed mention_roles from the is_mentioned check to fix the multi-bot false positive (#440). As a side effect, role mentions (@BotRole) no longer trigger the bot — only direct user mentions (@BotUser) work.

This is the correct behavior:

• Role mentions are shared across bots and can cause false positives in multi-bot setups
• User mentions are unique per bot and unambiguous
• Discord autocomplete shows both options — users should pick the bot user, not the role

No code change needed — just documenting the intentional behavior change.